Remove hardcoded Ruby/Rails versions, add --rebuild flag
#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `rails-new` must be released to use any newly released versions of Ruby/Rails by default. To address this, I'd like to remove the fallback versions of Ruby/Rails in the CLI arguments. However, this will mean that the image name no longer contains the Rails version, and that can lead to a stale Rails version when running `rails-new` if it has been previously built. This commit addresses that by providing a `--rebuild` option which forces the container to be rebuilt and ensures the latest version of Rails is installed and used.
This enables `gem install rails` in the Dockerfile to always install the latest Rails version instead of the default value in `rails-new`.
This will prevent having to update and release a new version of `rails-new` when new versions of Ruby are released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --rebuild flag to force rebuilding the image
Currently,
rails-newmust be released to use any newly releasedversions of Ruby/Rails by default. To address this, I'd like to remove
the fallback versions of Ruby/Rails in the CLI arguments. However, this
will mean that the image name no longer contains the Rails version, and
that can lead to a stale Rails version when running
rails-newif ithas been previously built.
This commit addresses that by providing a
--rebuildoption whichforces the container to be rebuilt and ensures the latest version of
Rails is installed and used.
Remove default Rails version
This enables
gem install railsin the Dockerfile to always install thelatest Rails version instead of the default value in
rails-new.Replace default Ruby version with "latest"
This will prevent having to update and release a new version of
rails-newwhen new versions of Ruby are released.