Fix Supervisor monitoring in Puma's plugin #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puma fires up the background hooks before the ```on_booted``` event. Since the plugin registers the ```monitor_solid_queue``` after Puma is fully booted, it doesn't get executed. The fix is to move the ```monitor_solid_queue``` out of the ```on_booted``` and check whether the SolidQueue has started in the ```solid_queue_dead?```.
|
Most welcome, @rosa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puma fires up the background hooks before the
on_bootedevent. Since the plugin registers themonitor_solid_queueafter Puma is fully booted, it doesn't get executed.The fix is to move the
monitor_solid_queueout of theon_bootedand check whether the SolidQueue has started in thesolid_queue_dead?.Fixes #222
/cc @K0H205