Set successfully_enqueued in Job.enqueue
#603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though this will be overwritten by Active Job when called through `perform_later`. This is necessary for recurring tasks, where we run the `enqueue` callbacks manually and call `Job.enqueue`. We rely on `successfully_enqueued?` to know whether we need to record the recurring execution. We were setting that no matter what after calling `Job.enqueue` because we were relying on that to raise (which would be the case for Active Record errors). In the case of discarding it because of concurrency controls, the job is simply not persisted but no error is raised, which means we were trying to record a recurring execution without a persisted job, which would raise. Fixes #598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*(Even though this will be overwritten by Active Job when called through
perform_later.)This is necessary for recurring tasks, where we run the
enqueuecallbacks manually and callJob.enqueue. We rely onsuccessfully_enqueued?to know whether we need to record the recurring execution. We were setting that no matter what after callingJob.enqueuebecause we were relying on that to raise (which would be the case for Active Record errors).In the case of discarding it because of concurrency controls, the job is simply not persisted but no error is raised, which means we were trying to record a recurring execution without a persisted job, which would raise.
Fixes #598