Pass taskrc via environment variable to subprocess. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't find where the rc:{config_filename} option is documented and it
doesn't seem to work on taskwarrior 2.5.1.
ryneeverett
force-pushed
the
taskrc-env-variable
branch
from
cadde18 to
5931171
Compare
|
Maybe not important, but I’m fairly sure |
ryneeverett
added a commit
to ryneeverett/taskw
that referenced
this pull request
Jun 6, 2020
Similarly to ralphbean#134, passing description via description:{description} doesn't appear to be documented and can lead to problems. See GothenburgBitFactory/bugwarrior#733 and consider the following scenario: $ task --version 2.5.1 $ task add description:"depends filter does not work with ID" The expression could not be evaluated. $ task add "depends filter does not work with ID" Created task 1. I've tried variations of the previous with various quoting and shells and have gotten the same result.
ryneeverett
added a commit
to ryneeverett/taskw
that referenced
this pull request
Jun 6, 2020
Similarly to ralphbean#134, passing description via description:{description} doesn't appear to be documented and can lead to problems. See GothenburgBitFactory/bugwarrior#733 and consider the following scenario: ```sh $ task --version 2.5.1 $ task add description:"depends filter does not work with ID" The expression could not be evaluated. $ task add "depends filter does not work with ID" Created task 1. ``` I've tried variations of the previous with various quoting and shells and have gotten the same result.
|
I can confirm that |
|
Thanks for the feedback. My reasoning was wrong but now that I understand it better I still think the patch is defensible. I've updated the PR description accordingly. |
coddingtonbear
approved these changes
Dec 6, 2020
ryneeverett
added a commit
to ryneeverett/taskw
that referenced
this pull request
Dec 7, 2020
Similarly to ralphbean#134, passing description via description:{description} doesn't appear to be documented and can lead to problems. See GothenburgBitFactory/bugwarrior#733 and consider the following scenario: ```sh $ task --version 2.5.1 $ task add description:"depends filter does not work with ID" The expression could not be evaluated. $ task add "depends filter does not work with ID" Created task 1. ``` I've tried variations of the previous with various quoting and shells and have gotten the same result.
ryneeverett
added a commit
to ryneeverett/taskw
that referenced
this pull request
Dec 8, 2020
Similarly to ralphbean#134, passing description via description:{description} doesn't appear to be documented and can lead to problems. See GothenburgBitFactory/bugwarrior#733 and consider the following scenario: ```sh $ task --version 2.5.1 $ task add description:"depends filter does not work with ID" The expression could not be evaluated. $ task add "depends filter does not work with ID" Created task 1. ``` I've tried variations of the previous with various quoting and shells and have gotten the same result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #131.
I can't find where the rc:{config_filename} option is documented and itdoesn't seem to work on taskwarrior 2.5.1.
The environment variable
TASKRCoverrides anrc:%sargument, which means if there is aTASKRCenvironment variable, it will override the value passed toconfig_filename. This is only a problem inTaskWarriorShelloutbecause subprocess inherits the environment.Alternatively, we could set
env={}in the subprocess call to isolate the environment, but this would be a more aggressive change and might not be desirable.I encountered this as a problem running the tests in an environment with the
TASKRCvariable defined, which causes the global taskrc (and therefore taskwarrior database) to be used by the test suite instead of the test configuration and database, which added a bunch of fake test data to my personal database. If this were the only issue we could do better environment isolation in the test suite. However, ignoringconfig_filenameisn't desirable for taskw library users either.