[REVIEW] Change default value of ordered to False in CategoricalDtype
#11604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
bdice
approved these changes
Aug 25, 2022
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Seems like a straightforward change. Thanks!
galipremsagar
added
4 - Needs Dask Reviewer
and removed
4 - Needs cuDF (Python) Reviewer
labels
bdice
reviewed
Aug 25, 2022
bdice
reviewed
Aug 25, 2022
galipremsagar
commented
Aug 26, 2022
shwina
approved these changes
Aug 26, 2022
galipremsagar
added
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11604 +/- ##
===============================================
Coverage ? 86.41%
===============================================
Files ? 145
Lines ? 23002
Branches ? 0
===============================================
Hits ? 19878
Misses ? 3124
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #11487
This PR switches default value of
orderedparameter inCategoricalDtypetoFalse. This fixes some issues around concat and building categorical columns.Checklist