Remove unneeded type check in cudf::strings::slice_strings #20437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
davidwendt
changed the title
|
/ok to test |
davidwendt
commented
Oct 30, 2025
| cudf::data_type_error); | ||
| CUDF_EXPECTS(is_fixed_width(starts_column.type()), | ||
| "Positions values must be fixed width type.", | ||
| cudf::data_type_error); |
There was a problem hiding this comment.
The indexalator-factory function below already checks these are valid index types.
davidwendt
added
3 - Ready for Review
vyasr
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unneeded type check on the
startsandstopscolumn parameters in thecudf::strings::slice_stringsAPI.Both types are checked for valid index-types (integers) but the starts/stops types themselves do not need to match.
Also, added a gtest to show this is possible and supported now.
Closes #20435
Checklist