Skip to content

Clean up Column Component View and Slot behaviours #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 11, 2025

Clean up and add tests for Component Views, and Slot behaviours

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.16%. Comparing base (1d83e0e) to head (bbe83cc).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
src/Views/Traits/Columns/HasSlot.php 58.33% 5 Missing ⚠️
src/Views/Columns/ComponentColumn.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2169      +/-   ##
=================================================
- Coverage          91.20%   91.16%   -0.04%     
+ Complexity          1991     1990       -1     
=================================================
  Files                212      212              
  Lines               4500     4496       -4     
=================================================
- Hits                4104     4099       -5     
- Misses               396      397       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 19b3723 into rappasoft:development Jan 11, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant