Revert the gRPC-based resource broadcast due to check failures during cluster autoscaling #16910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bfe8532.
ericl
requested review from
AmeerHajAli,
pcmoritz,
robertnishihara and
wuisawesome
as code owners
rkooo567
approved these changes
Jul 6, 2021
Contributor
rkooo567
left a comment
rkooo567
left a comment
There was a problem hiding this comment.
Is it going to be picked for 1.5.0? Seems like we need to rerun every test?
Contributor
Author
|
Yes, we need to pick this for 1.5 and likely 1.4.2 ( if we do that ).
…On Tue, Jul 6, 2021, 2:32 PM SangBin Cho ***@***.***> wrote:
***@***.**** approved this pull request.
Is it going to be picked for 1.5.0? Seems like we need to rerun every test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16910 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUSVHIGFRUMHWM7ZDAKDTWNZANANCNFSM475LWKAQ>
.
|
Contributor
Author
|
Seems this needs codeowners approval. |
Contributor
|
aren't you a code owner? |
wuisawesome
approved these changes
Jul 7, 2021
Contributor
Author
|
I don't think I can approve it myself though? |
Contributor
|
Oh interesting. Well it looks good now, maybe wait for tests then merge? |
jiaodong
pushed a commit
that referenced
this pull request
Jul 11, 2021
… cluster autoscaling (#16910)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR:
Related issue number
#16858