[autoscaler] Autoscaler hangs forever on non-zero exit code command #3969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @ls-daniel @richardliaw would be great to review this for the release |
| local_home = os.path.abspath(os.path.dirname(__file__)) | ||
| assert os.path.isdir(rllib_home), rllib_home | ||
|
|
||
| def do_link(package): |
Collaborator
There was a problem hiding this comment.
the changes in this file are unrelated, right?
Contributor
There was a problem hiding this comment.
This is for dev purposes (and are relatively harmless to include in this PR IMO)
Contributor
|
Despite the ugly git diffs, this is essentially only putting |
Contributor
Author
|
Yes
…On Wed, Feb 6, 2019, 3:27 PM Richard Liaw ***@***.***> wrote:
Despite the ugly git diffs, this is essentially only putting
provider.cleanup in a finally section for all ssh cmds and also amending
the rllib dev setup script right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3969 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA6SltsXQiQgGXBpsoY0aINuWQecMpIks5vK2TtgaJpZM4amTmq>
.
|
|
Test FAILed. |
richardliaw
approved these changes
Feb 6, 2019
Collaborator
|
Failing because of new gym release, see #3973. Should be unrelated. |
Contributor
|
All makes sense to me, apologies for delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Move provider.cleanup() to a finally block to avoid hanging.
Related issue number
Closes #3957