Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes following test failures.
test/actor_test.py::test_actors_and_tasks_with_gpusandtest/actor_test.py::test_actors_and_tasks_with_gpus_version_two. These two test cases failed since Stream logs to driver by default. #3892 . The test cases passed after I used longer waiting time. Did it take longer time to execute the task and one worker may had executed more than 1 task?test/runtest.py::test_multithreading: This test often failed in Python 2 environment. I replacedrandom_stringwith_random_string. In the Python 2 environment, there would be duplicated object ids. The oldrandom_stringmay have concurrent issue in multithread case, say it may generate the same random strings. Maybe we can remove it from our code.object_manager_test.ccfailed since Inline objects #3756 when VALGRIND is used. However, this test works fine in none-valgrind case. I increased the data size above the inline object threshold and the test passed. Maybe the owner needs to take a look at why the valgrind test fails when inline object is enabled.Related issue number
N/A