[core][gcs] Remove ByteSizeLong call from GcsTaskManager #41108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
|
Comparing the processing time for the task events thread with release tests: https://buildkite.com/ray-project/release/builds/1074 |
rkooo567
approved these changes
Nov 14, 2023
Signed-off-by: rickyyx <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
…#41108) We were tracking stored tasks event size from ByteSizeLong() calls, which is showing high overheads. Since we are already tracking the number of task attempts, we could get a proxy over the size and thus dropping the size tracking completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We were tracking stored tasks event size from ByteSizeLong() calls, which is showing high overheads. Since we are already tracking the number of task attempts, we could get a proxy over the size and thus dropping the size tracking completely.
Related issue number
Closes #41027
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.