[cd] unify image_exist #41230
Merged
[cd] unify image_exist #41230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-rel-02
branch
from
1831295 to
82b81ec
Compare
can-anyscale
changed the title
can-anyscale
commented
Nov 17, 2023
release/ray_release/byod/build.py
Outdated
Contributor
Author
There was a problem hiding this comment.
Removing this env-var while I'm here, the image is now built within the pipeline so there are no use cases for this
aslonnie
approved these changes
Nov 17, 2023
can-anyscale
force-pushed
the
can-rel-01
branch
from
1edd73b to
bb94f58
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-rel-02
branch
from
82b81ec to
43fb11c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two different functions for checking if a docker image exist. Unify them into one (especially because one of them doesn't work for gcp).
Test: