Skip to content

Conversation

@lk-chen
Copy link
Contributor

@lk-chen lk-chen commented May 21, 2025

Why are these changes needed?

Enable release test for P/D disagg. implemented in #53092. This PR includes:

Related issue number

RFC #53257
Ray-LLM Roadmap #51313

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@lk-chen lk-chen requested review from a team as code owners May 21, 2025 01:27
@lk-chen lk-chen force-pushed the pd_release_test branch 4 times, most recently from 393835d to 09b5523 Compare May 21, 2025 08:25
@lk-chen lk-chen force-pushed the pd_release_test branch 5 times, most recently from b7a6517 to 1191f64 Compare May 22, 2025 00:25
@lk-chen lk-chen force-pushed the pd_release_test branch from 1191f64 to 9155ec7 Compare May 22, 2025 01:07
@lk-chen lk-chen force-pushed the pd_release_test branch 2 times, most recently from 87dbbdc to a0c2f84 Compare May 23, 2025 01:10
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, I'll review once more when tests pass and this is rebased.

@lk-chen lk-chen requested review from a team, kevin85421 and pcmoritz as code owners May 23, 2025 19:30
@lk-chen lk-chen force-pushed the pd_release_test branch from 55b599b to 78153e3 Compare May 23, 2025 19:49
@lk-chen lk-chen removed request for a team May 23, 2025 19:49
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kouroshHakha
Copy link
Contributor

@lk-chen conflict?

lk-chen added 14 commits May 28, 2025 14:49
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
@lk-chen lk-chen force-pushed the pd_release_test branch 2 times, most recently from 9f66469 to 9c273df Compare May 28, 2025 21:55
Signed-off-by: Linkun Chen <[email protected]>
@lk-chen lk-chen force-pushed the pd_release_test branch from 9c273df to 540d793 Compare May 28, 2025 21:56
@kouroshHakha kouroshHakha enabled auto-merge (squash) May 28, 2025 22:00
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval for the byod script. nice job!

@kouroshHakha kouroshHakha merged commit f9f0129 into ray-project:master May 28, 2025
5 of 6 checks passed
@lk-chen lk-chen deleted the pd_release_test branch May 28, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests llm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants