-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Serve.llm] Pin Ray version for DeepSeek example #54926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve.llm] Pin Ray version for DeepSeek example #54926
Conversation
Signed-off-by: Seiji Eicher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @eicherseiji, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses critical compatibility issues preventing the successful deployment of the DeepSeek example with Ray Serve. By specifically pinning the Ray version and adjusting a key configuration parameter, I've ensured the example functions correctly, mitigating known PicklingError
and other deployment failures.
Highlights
- Dependency Pinning: I've pinned the
ray[llm]
dependency to version2.46.0
in the DeepSeek example's installation instructions. This is crucial because newer Ray versions (up to 2.48) introduce bugs that prevent the successful deployment of DeepSeek models. - Configuration Adjustment: I've removed the
trust_remote_code: True
parameter from both the PythonLLMConfig
and the YAML deployment configuration for the DeepSeek example. This change is necessary to avoidPicklingError
issues that arise whentrust_remote_code
is enabled with certain Ray versions, as detailed in a relatedvllm-project
pull request.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request pins the Ray version to 2.46.0
and removes trust_remote_code
to resolve a PicklingError
when deploying DeepSeek models. I've added suggestions to the documentation to explain why this specific version is necessary and why trust_remote_code
was removed, which will improve clarity and prevent future confusion.
Signed-off-by: Seiji Eicher <[email protected]>
36cd835
to
7c150ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Krishna Kalyan <[email protected]>
Signed-off-by: jugalshah291 <[email protected]>
Signed-off-by: Douglas Strodtman <[email protected]>
Why are these changes needed?
Need to pin Ray 2.46 +
trust_remote_code: False
, otherwise, will fail withPicklingError
due to vllm-project/vllm#18640Newer Ray versions (up to and including 2.48) have other bugs that prevent deploying DeepSeek.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.