Skip to content

Conversation

elsassph
Copy link
Contributor

@elsassph elsassph commented Apr 24, 2025

Element's texture instance doesn't receive the RTL flag in some scenarios due to the "side-effects optimisation" in ElementCore, this causes text alignment to not be automatically mirrored (e.g. left alignment becoming right).

Note:

  • the bug doesn't happen with the classic component templating approach, only when manually creating elements,
  • test file was reformatted, the main addition is the new it("Should propagate flag after attachment" new last case, plus a few assertions that labels were rendered with the right direction flag.

In this screenshot, before the bug, the "Dynamic attachment" label would remain left-aligned instead of being right aligned with the blue box as we can see here:
image

@elsassph elsassph force-pushed the fix/rtl-text-propagation branch from 390252c to 5bf481b Compare April 24, 2025 13:31
@amurillo-wm
Copy link

Tested locally and text is mirrored properly

Copy link
Contributor

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michielvandergeest michielvandergeest merged commit a8d1d4f into rdkcentral:feature/rtl Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants