Fix text texture RTL propagation #570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element
'stexture
instance doesn't receive the RTL flag in some scenarios due to the "side-effects optimisation" inElementCore
, this causes text alignment to not be automatically mirrored (e.g.left
alignment becomingright
).Note:
it("Should propagate flag after attachment"
new last case, plus a few assertions that labels were rendered with the right direction flag.In this screenshot, before the bug, the "Dynamic attachment" label would remain left-aligned instead of being right aligned with the blue box as we can see here:
