-
Notifications
You must be signed in to change notification settings - Fork 2
TDK-10019 Enhance ut-core framework for listing test-cases #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please raise a ticket on ut-core, describe the problem that you're trying to solve by raising an issue on the git repo, and then branch the code..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we extended the size to ensure that we handle the extended name sizes because the autogenerated code generally had larger names, but we wanted also to ensure that it was visible across both C & C++.
We also want engineers to enure that they do not make functions names > that the actual fixed size, it's important to ensure they do not for both C & C++.
Therefore, the design and the of fixed spacing and truncated names is the design and the current requirement.
What problem you're actually trying to solve here? Do you have function names > 64 characters?
|
Hi @Abhishek-0412, We tried your changes and had a look at it visually. Thanks cc : @Ulrond |
|
I understand the intent behind maintaining a fixed width layout in the console logs, My initial concern was primarily around truncated function names, which can make it hard to quickly identify failing test cases, If we are standardizing on keeping function names within a 64-character limit as a coding guideline, I am completely ok with that approach. It addresses the concern without changing the console display logic. |

Enhance ut-core framework to print testcases properly
Test case width is hardcoded to a 34 in ut-core framework.
If the testcase name is greater than 34 , while displaying testcase name in console its truncated.
In later version of ut-core, 34 is changed to UT_MAX_LENGTH_TEST_NAME_DISPLAYED (64) , which is not an ideal solution.
d5b15c7
Handled using dynamic approach by allocating the width by parsing through all the testcase names and setting width to maxTestNameLength.
https://jira.rdkcentral.com/jira/browse/TDK-10019