RDKEMW-5927: Crash fix during soup_uri_to_string API call #163
Conversation
Signed-off-by: yuvaramachandran_gurusamy <[email protected]>
Coverity Issue - Variable copied when it could be moved"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"applicationName" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""applicationName"")" instead of "applicationName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appId"")" instead of "appId". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appId"")" instead of "appId". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"strQuery" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""strQuery"")" instead of "strQuery". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"AddDataUrl" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""AddDataUrl"")" instead of "AddDataUrl". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warninga value of type "int" cannot be used to initialize an entity of type "SoupServerListenOptions" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "payload". Field "payload.user_param1" is uninitialized when calling "sendRequest". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"activation" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""activation"")" instead of "activation". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appID"")" instead of "appID". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"model" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""model"")" instead of "model". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"powerState" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""powerState"")" instead of "powerState". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"applicationId" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""applicationId"")" instead of "applicationId". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"strPayLoad" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""strPayLoad"")" instead of "strPayLoad". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appID"")" instead of "appID". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appId"")" instead of "appId". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"parameter" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""parameter"")" instead of "parameter". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"error" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""error"")" instead of "error". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appID"")" instead of "appID". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"strAddDataUrl" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""strAddDataUrl"")" instead of "strAddDataUrl". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"query" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""query"")" instead of "query". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appState" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appState"")" instead of "appState". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"friendlyname" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""friendlyname"")" instead of "friendlyname". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningfunction "gdialServiceImpl::start_GDialServer" not emitted, consider modeling it or review parse diagnostics to improve fidelity Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appName"")" instead of "appName". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appId"")" instead of "appId". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""appID"")" instead of "appID". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"parameter" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""parameter"")" instead of "parameter". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"payload" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""payload"")" instead of "payload". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"manufacturer" is copied in call to copy assignment for class "std::string", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""manufacturer"")" instead of "manufacturer". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse recovery warningargument of type "const char *" is incompatible with parameter of type "gpointer" Low Impact, CWE-none Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
* RDKECMF-213 Add CODEOWNERS file * RDKEMW-254: libsoup3 support Signed-off-by: apatel859 <[email protected]> * RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssdp_set_friendlyname Signed-off-by: yuvaramachandran_gurusamy <[email protected]> * RDKEMW-2033: Fix coverity related issue Reason for change: Fix issues identified within xcast Test Procedure: Risks: low Priority: P1 Signed-off-by:Hayden Gfeller <[email protected]> * RDK-55044: [RDKE] Implement DIAL requirement to use on EU product Reason for change: Implemented setManufacturerName and setModelName APIs for DIAL Server name configuration maintained the additional data url to specific app Test Procedure: DIAL should work Risks: None Priority: P1 Signed-off-by: yuvaramachandran_gurusamy <[email protected]> * RDK-56672: Fix parsing issue while restrict addtionalData url per app Signed-off-by: yuvaramachandran_gurusamy <[email protected]> * RDKEMW-2278: Removal of WPEFrameworkSecurity Agent Utility Reason for change: Added DISABLE_SECURITY_TOKEN Flag to disable the WPEFrameworkSecurity Token generation changes Test Procedure: please referred from the ticket Risks: Medium Signed-off-by: Thamim Razith <[email protected]> * RDKEMW-4129: Prepare native build environment Signed-off-by: yuvaramachandran_gurusamy <[email protected]> * RDKEMW-4129: Test Signed-off-by: yuvaramachandran_gurusamy <[email protected]> * RDKEMW-4129: Prepare native build script Signed-off-by: yuvaramachandran_gurusamy <[email protected]> * remmove duplicates from build_xxx script Signed-off-by: apatel859 <[email protected]> * Update gdial.cpp * RDKEMW-5927: Crash fix during soup_uri_to_string API call (#163) Signed-off-by: yuvaramachandran_gurusamy <[email protected]> * RDKEMW-6891:Coverity errors fix for xdial (#166) * RDKEMW-6891: Coverity errors fix for xdial * Update gdial.cpp Fixed review comments * Deploy cla action --------- Signed-off-by: apatel859 <[email protected]> Signed-off-by: yuvaramachandran_gurusamy <[email protected]> Signed-off-by: Thamim Razith <[email protected]> Co-authored-by: Simon Chung <[email protected]> Co-authored-by: Stephen Barrett <[email protected]> Co-authored-by: apatel859 <[email protected]> Co-authored-by: apatel859 <[email protected]> Co-authored-by: hgfell683 <[email protected]> Co-authored-by: tabbas651 <[email protected]> Co-authored-by: ssitar583 <[email protected]> Co-authored-by: mukesh972 <[email protected]> Co-authored-by: rdkcmf <[email protected]> Co-authored-by: Alan Ryan <[email protected]>
* RDKECMF-213 Add CODEOWNERS file * RDKEMW-254: libsoup3 support * RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssdp_set_friendlyname * RDKEMW-2033: Fix coverity related issue * RDK-55044: [RDKE] Implement DIAL requirement to use on EU product * RDK-56672: Fix parsing issue while restrict addtionalData url per app * RDKEMW-2278: Removal of WPEFrameworkSecurity Agent Utility * RDKEMW-4129: Prepare native build environment * RDKEMW-4129: Test * RDKEMW-4129: Prepare native build script * remmove duplicates from build_xxx script * Update gdial.cpp * RDKEMW-5927: Crash fix during soup_uri_to_string API call (#163) * RDKEMW-6891:Coverity errors fix for xdial (#166) * RDKEMW-6891: Coverity errors fix for xdial * Update gdial.cpp Fixed review comments * Deploy cla action --------- Signed-off-by: apatel859 <[email protected]> Signed-off-by: yuvaramachandran_gurusamy <[email protected]> Signed-off-by: Thamim Razith <[email protected]> Co-authored-by: Simon Chung <[email protected]> Co-authored-by: Stephen Barrett <[email protected]> Co-authored-by: apatel859 <[email protected]> Co-authored-by: apatel859 <[email protected]> Co-authored-by: hgfell683 <[email protected]> Co-authored-by: tabbas651 <[email protected]> Co-authored-by: ssitar583 <[email protected]> Co-authored-by: mukesh972 <[email protected]> Co-authored-by: rdkcmf <[email protected]> Co-authored-by: Alan Ryan <[email protected]>
3 participants
RDKEMW-5927: Crash fix during soup_uri_to_string API call
Signed-off-by: yuvaramachandran_gurusamy [email protected]