Skip to content

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 7, 2020

fix #212

@vercel
Copy link

vercel bot commented Dec 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/ecwzh0psb
✅ Preview: https://dialog-git-fix-re-render.react-component.vercel.app

@zombieJ zombieJ requested a review from chenshuai2144 December 7, 2020 07:04
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #217 (00434e4) into master (716f1a8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   98.08%   98.10%   +0.01%     
==========================================
  Files           6        6              
  Lines         157      158       +1     
  Branches       45       46       +1     
==========================================
+ Hits          154      155       +1     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/Dialog/Content/MemoChildren.tsx 100.00% <100.00%> (ø)
src/Dialog/Content/index.tsx 95.34% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716f1a8...00434e4. Read the comment docs.

@zombieJ zombieJ merged commit c4e36e4 into master Dec 7, 2020
@zombieJ zombieJ deleted the fix-re-render branch December 7, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants