Skip to content

fix: IDialogPropTypes import #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2020
Merged

fix: IDialogPropTypes import #25

merged 5 commits into from
Sep 2, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Sep 2, 2020

close #24

@vercel
Copy link

vercel bot commented Sep 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/j5zomlutm
✅ Preview: https://image-git-fix-idialogproptypes.react-component.vercel.app

@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          137       137           
  Branches        31        31           
=========================================
  Hits           137       137
Impacted Files Coverage Δ
src/Preview.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063e4cd...ba7db7b. Read the comment docs.

@xrkffgg xrkffgg requested a review from shaodahong September 2, 2020 01:46
@xrkffgg
Copy link
Member Author

xrkffgg commented Sep 2, 2020

怎么对 snap 还有了影响。。。

shaodahong
shaodahong reviewed Sep 2, 2020
View reviewed changes
src/Preview.tsx Outdated
import * as React from 'react';
import Dialog from 'rc-dialog';
import IDialogPropTypes from 'rc-dialog/lib/IDialogPropTypes';
import { IDialogPropTypes } from 'rc-dialog/lib/IDialogPropTypes';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要这样引入了，不然以后还会有问题，从 rc-dialog 去引

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { DialogProps as IDialogPropTypes } from 'rc-dialog' 这样导入，rc-dialog 有导出这个，名字换了。

@shaodahong
Copy link
Member

怎么对 snap 还有了影响。。。

因为导出方式变了，感觉最好加个 displayName

@xrkffgg xrkffgg mentioned this pull request Sep 2, 2020
Merged
@afc163
Copy link
Member

afc163 commented Sep 2, 2020

+ [email protected]

@kerm1it kerm1it mentioned this pull request Sep 2, 2020
Merged
xrkffgg
xrkffgg commented Sep 2, 2020
View reviewed changes
@xrkffgg
Copy link
Member Author

xrkffgg commented Sep 2, 2020

😂😂😂 昨晚莫名其妙的，想去 compile 下 image

@xrkffgg xrkffgg requested a review from shaodahong September 2, 2020 07:14
@shaodahong shaodahong merged commit c9fef04 into master Sep 2, 2020
@shaodahong shaodahong deleted the fix-IDialogPropTypes branch September 2, 2020 08:33
@shaodahong
Copy link
Member

+ [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerm1it kerm1it kerm1it left review comments

@shaodahong shaodahong Awaiting requested review from shaodahong

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

yarn compile

4 participants

@xrkffgg @shaodahong @afc163 @kerm1it