Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 22, 2021

Pure render popup without state update will get empty list since popup is not ready yet.

@vercel
Copy link

vercel bot commented Jun 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/Ck933KTP8ybZemg8sRSonMESiVJN
✅ Preview: https://select-git-fix-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #640 (93a80a2) into master (9c7a949) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   99.08%   99.09%           
=======================================
  Files          20       20           
  Lines         989      990    +1     
  Branches      322      321    -1     
=======================================
+ Hits          980      981    +1     
  Misses          8        8           
  Partials        1        1           
Impacted Files Coverage Δ
src/generate.tsx 99.38% <100.00%> (ø)
src/hooks/useSelectTriggerControl.ts 93.75% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7a949...93a80a2. Read the comment docs.

@zombieJ zombieJ merged commit 3ad6556 into master Jun 22, 2021
@zombieJ zombieJ deleted the fix branch June 22, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant