fix: tipFormatter should not crash with undefined value #1053
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Caution Review failedThe pull request is closed. 概述代码变更解析步骤说明本次变更主要涉及两个文件： 变更
序列图sequenceDiagram
participant Component as Tracks组件
participant Data as trackList数据
Component->>Data: 安全访问trackList长度
alt 数据存在
Data-->>Component: 返回长度
else 数据为空/未定义
Data-->>Component: 返回undefined
end
诗歌
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
afc163
reviewed
Dec 31, 2024
| }); | ||
| it('tipFormatter should not crash with undefined value', () => { | ||
| [undefined, null].forEach((value) => { | ||
| render(<Slider value={value} tooltip={{ open: true }} styles={{ tracks: {} }}/>); |
Member
There was a problem hiding this comment.
兼容的是 styles={{ tracks: {} }} 还是 value={null} ？
Contributor
Author
There was a problem hiding this comment.
这个单测是antd搬过来的，兼容的是value={null}，在styles.tracks存在时，如果trackList.length不存在的话就会报错。
afc163
reviewed
Dec 31, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当使用 classNames.tracks || styles.tracks 的时候 undefined和null 的单测就会报错。
Summary by CodeRabbit
Bug 修复
Tracks组件中添加了可选链接，提高了代码的健壮性，防止在空列表或未定义的情况下出现错误。测试
Slider组件添加了新的测试用例，确保在处理未定义或空值时不会崩溃。