Skip to content

Conversation

@dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Sep 13, 2019

Summary:

RN modules don't need to include Android Gradle Plugin because it's included in App project, and version its mismatch between app and module causes issues.

This PR removes Android Gradle Plugin from android or module project, and created a root project, creating build.gradle.kts file, so that we can develop with Android Studio. Also removed buildToolsVersion because it's no longer required by Android Gradle Plugin. Then changed minSdkVersion to be 16 to comply with RN.

Once this PR merged, developers need to open async-storage in Android Studio instead of android folder inside it.

Test Plan:

The module will work as usual and expected

@dulmandakh
Copy link
Contributor Author

@krizzu please review and merge

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dulmandakh Thank you for the contribution! This looks great, left a question and small comment for you.

@dulmandakh
Copy link
Contributor Author

@krizzu fixed, please merge

@friederbluemle
Copy link
Contributor

Hi @dulmandakh - What kind of issues were you seeing when there is a mismatch of the the app project and a module? Can you please link me to an example?

@krizzu
Copy link
Member

krizzu commented Sep 17, 2019

@dulmandakh Actually, I think we don't need to have gradle project in the root. When developing AsyncStorage, you'd normally do it by using Android App - which we have, in example directory and it's already using AsyncStorage module as subproject.

Can you checkout changes with build.gradle.kts and executables please?

@dulmandakh
Copy link
Contributor Author

@krizzu removed Gradle wrapper

@friederbluemle
Copy link
Contributor

@krizzu @dulmandakh - Please check a slightly different approach here: #209 - It achieves the same result (avoiding unnecessary dependency downloads/conflicts in an app project), but keeps the buildscript dependency in place. With this it is still possible to open the android folder in Android Studio, and build this library stand-alone.

@krizzu
Copy link
Member

krizzu commented Sep 18, 2019

Closing in favor of #209

@krizzu krizzu closed this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants