Skip to content

fix: Fix watchMode process logs not showing color #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: Fix watchMode process logs not showing color #2052

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e256b7
fix: Fix watchMode process logs not showing color
SubsequentlySneeds Aug 8, 2023
c41f131
Merge branch 'main' into main-1
SubsequentlySneeds Aug 17, 2023
12e598a
Refactor watchMode color options
SubsequentlySneeds Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions packages/cli-plugin-metro/src/commands/start/watchMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ function enableWatchMode(messageSocket: any, ctx: Config) {
}
});

const execaOptions = {
env: {FORCE_COLOR: chalk.supportsColor ? 'true' : 'false'},
};

const onPress = (key: string) => {
switch (key) {
case 'r':
Expand All @@ -53,19 +57,27 @@ function enableWatchMode(messageSocket: any, ctx: Config) {
break;
case 'i':
logger.info('Opening app on iOS...');
execa('npx', [
'react-native',
'run-ios',
...(ctx.project.ios?.watchModeCommandParams ?? []),
]).stdout?.pipe(process.stdout);
execa(
'npx',
[
'react-native',
'run-ios',
...(ctx.project.ios?.watchModeCommandParams ?? []),
],
execaOptions,
).stdout?.pipe(process.stdout);
break;
case 'a':
logger.info('Opening app on Android...');
execa('npx', [
'react-native',
'run-android',
...(ctx.project.android?.watchModeCommandParams ?? []),
]).stdout?.pipe(process.stdout);
execa(
'npx',
[
'react-native',
'run-android',
...(ctx.project.android?.watchModeCommandParams ?? []),
],
execaOptions,
).stdout?.pipe(process.stdout);
break;
case CTRL_Z:
process.emit('SIGTSTP', 'SIGTSTP');
Expand Down