0.58.3 Discussion

[grabbou]

Conversation on this thread are limited to 0.58.0 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.58.4 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.3 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

[Jyrno42]

• Android: Add error description to Image onError callback: facebook/react-native@7795a67

[Bardiamist]

• In flow-bin@0.87.0 was added React.lazy and React.memo definitions.
  facebook/react-native@ef2084c

I created react-native@0.58.0 project and here flow-bin@0.85.0 (not flow-bin@0.86.0 as desribed in changelog) therefore required and flow-bin0.86.0 commit facebook/react-native@8fb228f

[zenz]

flow still not work under windows. but arm64 supported is a good thing.

[grabbou]

@Bardiamist looks like the Flow 0.86 commit has been reverted by a mistake few commits after. I am not entirely sure how it happened, I am going to check it and release a patch.

[grabbou]

Looks like Flow commit was not the only one that was accidentally reverted while we were working on a 0.58 release candidate. Apologies for the confusion, as the commits were listed in the changelog.

Here is a full list of commits that are being released under 0.58.2: facebook/react-native@de60e86...8f283b9

[malonguwa]

@grabbou Does 64-bit version android release build included in the 0.58.x?

[mikehardy]

@malonguwa - easy enough to check: https://github.com/facebook/react-native/blob/v0.58.3/local-cli/templates/HelloWorld/android/app/build.gradle#L112

[malonguwa]

@mikehardy thanks for the info~ I go through the related PR, I could not find the merged PR for this change, and also there is no any info in the 0.58 changelog, but I do see a comment in
facebook/react-native#2814 (comment)

Maybe we should wait till RN 0.59 ?

[mikehardy]

@malonguwa - ah - I see what you mean, thanks for the link to that comment. I suppose this must be related to the JSC upgrade, which will land with 0.59 and I suppose the link I sent to the code line was necessary infrastructure but doesn't meet the Play Store requirement that all the included libraries are 64-bit as well. 0.59 is coming shortly either way so not long of a wait.

[mikehardy]

For anyone else upgrading, it might be worth mentioning that an npm install was not sufficient for me (it failed because the metro packager could not find bundle/unbundle.js). I had to purge node_modules then npm install, then (with some consultation of the https://github.com/pvinis/rn-diff-purge project run locally to generate diffs) everything appeared to work fine in my app

[kelset]

Yes I kept an eye on the issues and it seems that when migrating to 0.58 from 0.57 there is only one small native side change required -> facebook/react-native#23183 (comment)