Skip to content

fix(169) issue #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix(169) issue #175

merged 1 commit into from
Aug 19, 2020

Conversation

numandev1
Copy link
Contributor

Summary

i have fixed notification.getTitle() and notification.getMessage() method
fixed #169 #147

Naturalclar
Naturalclar approved these changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've tested locally and confirmed that it shows title and body 👍

@Naturalclar Naturalclar merged commit 8a4bae9 into react-native-push-notification:master Aug 19, 2020
@Dallas62
Copy link
Contributor

Hi @Naturalclar
I'm not sure this is working well, please take a look to:
#147 (comment)

This might have impacted remote side.

This was referenced Nov 21, 2020
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

getMessage() method returns undefined in the notification handler

3 participants

@numandev1 @Dallas62 @Naturalclar