Skip to content

Conversation

8BallBomBom
Copy link
Member

I feel that we actually need a TypeScript remake and a proper cleanup.
But this should do for now 👍🏻

Fixes #3.

@saghul
Copy link
Member

saghul commented Sep 5, 2023

Feel free to land it when the CI is happy :-)

@8BallBomBom
Copy link
Member Author

Ahahahaha that is a good one 🤔 will investigate.
But will also need permissions nudging up 😅

@saghul
Copy link
Member

saghul commented Sep 5, 2023

Fixed the permissions :-)

@8BallBomBom
Copy link
Member Author

Thanks as always, will see what i can do 👍🏻

@OlliePugh
Copy link

I can't see the CI for this, but is there any idea of when this will get merged? 🙏

@8BallBomBom
Copy link
Member Author

8BallBomBom commented Oct 1, 2023

Technically it could be merged now, just the CI being a bit funky.
But there is another issue that i'm trying to resolve relating to releasing the update on the main NPM registry.

@OlliePugh
Copy link

Ahh okay, where is the CI? I can't see github actions running on this PR? 🤔

@8BallBomBom
Copy link
Member Author

Pretty much binned them until i was sure of things actually working but they will run again soon.
Chances are the browser tests might be thrown out and replaced with nothing or an updated alternative.

@8BallBomBom
Copy link
Member Author

8BallBomBom commented Oct 4, 2023

Going to push this up, do a release and fix the GH Actions at a later time.
Only real issue though is getting the package updated and released properly on the main NPM Registry.


Edit:

Alrighty, that has been resolved and the latest update is now on the main NPM registry.

@8BallBomBom 8BallBomBom merged commit 6a56d5f into react-native-webrtc:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

got error while installation
3 participants