(housekeeping) Upgraded Xamarin.Forms to v3.4 (#1942)

RLittlesII · glennawatson · commit f1ad8a0e1ec1 · 2019-02-08T18:36:14.000Z
* (housekeeping) Upgraded Xamarin.Forms to v3.4
diff --git a/integrationtests/IntegrationTests.XamarinForms/IntegrationTests.XamarinForms.csproj b/integrationtests/IntegrationTests.XamarinForms/IntegrationTests.XamarinForms.csproj
@@ -7,7 +7,7 @@
   <ItemGroup>
     <PackageReference Include="Acr.UserDialogs" Version="7.0.1" />
     <PackageReference Include="ReactiveUI.XamForms" Version="*" />
-    <PackageReference Include="Xamarin.Forms" Version="3.3.*" />
+    <PackageReference Include="Xamarin.Forms" Version="3.4.*" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/src/EventBuilder/Platforms/Essentials.cs b/src/EventBuilder/Platforms/Essentials.cs
@@ -29,7 +29,7 @@ public class Essentials : BasePlatform
         public override AutoPlatform Platform => AutoPlatform.Essentials;
 
         /// <inheritdoc />
-        public async override Task Extract()
+        public override async Task Extract()
         {
             var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform).ConfigureAwait(false);
 
diff --git a/src/EventBuilder/Platforms/Tizen.cs b/src/EventBuilder/Platforms/Tizen.cs
@@ -29,7 +29,7 @@ public class Tizen : BasePlatform
         public override AutoPlatform Platform => AutoPlatform.Tizen4;
 
         /// <inheritdoc />
-        public async override Task Extract()
+        public override async Task Extract()
         {
             var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform, FrameworkConstants.CommonFrameworks.Tizen4).ConfigureAwait(false);
 
diff --git a/src/EventBuilder/Platforms/XamForms.cs b/src/EventBuilder/Platforms/XamForms.cs
@@ -21,14 +21,14 @@ public class XamForms : BasePlatform
     {
         private readonly PackageIdentity[] _packageNames = new[]
         {
-            new PackageIdentity("Xamarin.Forms", new NuGetVersion("3.3.0.967583")),
+            new PackageIdentity("Xamarin.Forms", new NuGetVersion("3.4.0.1029999")),
         };
 
         /// <inheritdoc />
         public override AutoPlatform Platform => AutoPlatform.XamForms;
 
         /// <inheritdoc />
-        public async override Task Extract()
+        public override async Task Extract()
         {
             var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform).ConfigureAwait(false);
 
diff --git a/src/ReactiveUI.Events.XamForms/ReactiveUI.Events.XamForms.csproj b/src/ReactiveUI.Events.XamForms/ReactiveUI.Events.XamForms.csproj
@@ -16,7 +16,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Xamarin.Forms" Version="3.3.*" />
+    <PackageReference Include="Xamarin.Forms" Version="3.4.*" />
     <Compile Include="Events_XAMFORMS.cs" />
   </ItemGroup>
 </Project>
diff --git a/src/ReactiveUI.XamForms/ReactiveUI.XamForms.csproj b/src/ReactiveUI.XamForms/ReactiveUI.XamForms.csproj
@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Xamarin.Forms" Version="3.3.*" />
+    <PackageReference Include="Xamarin.Forms" Version="3.4.*" />
   </ItemGroup>
 
   <ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public class Essentials : BasePlatform`
`29`	`29`	`public override AutoPlatform Platform => AutoPlatform.Essentials;`
`30`	`30`
`31`	`31`	`/// <inheritdoc />`
`32`		`- public async override Task Extract()`
	`32`	`+ public override async Task Extract()`
`33`	`33`	`{`
`34`	`34`	`var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform).ConfigureAwait(false);`
`35`	`35`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public class Tizen : BasePlatform`
`29`	`29`	`public override AutoPlatform Platform => AutoPlatform.Tizen4;`
`30`	`30`
`31`	`31`	`/// <inheritdoc />`
`32`		`- public async override Task Extract()`
	`32`	`+ public override async Task Extract()`
`33`	`33`	`{`
`34`	`34`	`var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform, FrameworkConstants.CommonFrameworks.Tizen4).ConfigureAwait(false);`
`35`	`35`
Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,14 @@ public class XamForms : BasePlatform`
`21`	`21`	`{`
`22`	`22`	`private readonly PackageIdentity[] _packageNames = new[]`
`23`	`23`	`{`
`24`		`- new PackageIdentity("Xamarin.Forms", new NuGetVersion("3.3.0.967583")),`
	`24`	`+ new PackageIdentity("Xamarin.Forms", new NuGetVersion("3.4.0.1029999")),`
`25`	`25`	`};`
`26`	`26`
`27`	`27`	`/// <inheritdoc />`
`28`	`28`	`public override AutoPlatform Platform => AutoPlatform.XamForms;`
`29`	`29`
`30`	`30`	`/// <inheritdoc />`
`31`		`- public async override Task Extract()`
	`31`	`+ public override async Task Extract()`
`32`	`32`	`{`
`33`	`33`	`var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform).ConfigureAwait(false);`
`34`	`34`