Skip to content

Conversation

RLittlesII
Copy link
Member

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Upgrade Xamarin.Forms to version 3.4

What is the current behavior? (You can also link to an open issue here)

Xamarin.Forms targets version 3.3

What is the new behavior (if this is a feature change)?

Xamarin.Forms targets version 3.4

What might this PR break?

Xamarin.Forms based controls

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@RLittlesII RLittlesII requested review from a team February 8, 2019 14:51
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #1942 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1942   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files          99       99           
  Lines        4815     4815           
  Branches      465      465           
=======================================
  Hits         3245     3245           
  Misses       1443     1443           
  Partials      127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ceddd1...1dbcd4c. Read the comment docs.

worldbeater
worldbeater previously approved these changes Feb 8, 2019
Copy link
Contributor

@glennawatson glennawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the event builder also.

@RLittlesII
Copy link
Member Author

I attempted to change the Xamarin version in the Platform to 3.4.*, seems that depends on a full semantic version to resolve correctly.

@glennawatson glennawatson merged commit 9f4392b into reactiveui:master Feb 8, 2019
@RLittlesII RLittlesII deleted the xamarin branch February 15, 2019 16:07
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
* (housekeeping) Upgraded Xamarin.Forms to v3.4
@lock lock bot locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants