Skip to content

(housekeeping) Upgraded Xamarin.Forms to v3.4 #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2019
Merged

(housekeeping) Upgraded Xamarin.Forms to v3.4 #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1685bb8
(housekeeping) Upgraded Xamarin.Forms to v3.4
RLittlesII Feb 8, 2019
b50ea81
Changed EventBuilder to use Xamarin.Forms 3.4.*
RLittlesII Feb 8, 2019
1dbcd4c
Reverting Xamarin.Forms NuGetVersion change
RLittlesII Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrationtests/IntegrationTests.XamarinForms/IntegrationTests.XamarinForms.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<ItemGroup>
<PackageReference Include="Acr.UserDialogs" Version="7.0.1" />
<PackageReference Include="ReactiveUI.XamForms" Version="*" />
<PackageReference Include="Xamarin.Forms" Version="3.3.*" />
<PackageReference Include="Xamarin.Forms" Version="3.4.*" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/EventBuilder/Platforms/Essentials.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class Essentials : BasePlatform
public override AutoPlatform Platform => AutoPlatform.Essentials;

/// <inheritdoc />
public async override Task Extract()
public override async Task Extract()
{
var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform).ConfigureAwait(false);

Expand Down
2 changes: 1 addition & 1 deletion src/EventBuilder/Platforms/Tizen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class Tizen : BasePlatform
public override AutoPlatform Platform => AutoPlatform.Tizen4;

/// <inheritdoc />
public async override Task Extract()
public override async Task Extract()
{
var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform, FrameworkConstants.CommonFrameworks.Tizen4).ConfigureAwait(false);

Expand Down
4 changes: 2 additions & 2 deletions src/EventBuilder/Platforms/XamForms.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ public class XamForms : BasePlatform
{
private readonly PackageIdentity[] _packageNames = new[]
{
new PackageIdentity("Xamarin.Forms", new NuGetVersion("3.3.0.967583")),
new PackageIdentity("Xamarin.Forms", new NuGetVersion("3.4.0.1029999")),
};

/// <inheritdoc />
public override AutoPlatform Platform => AutoPlatform.XamForms;

/// <inheritdoc />
public async override Task Extract()
public override async Task Extract()
{
var packageUnzipPath = await NuGetPackageHelper.InstallPackages(_packageNames, Platform).ConfigureAwait(false);

Expand Down
2 changes: 1 addition & 1 deletion src/ReactiveUI.Events.XamForms/ReactiveUI.Events.XamForms.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Xamarin.Forms" Version="3.3.*" />
<PackageReference Include="Xamarin.Forms" Version="3.4.*" />
<Compile Include="Events_XAMFORMS.cs" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/ReactiveUI.XamForms/ReactiveUI.XamForms.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Xamarin.Forms" Version="3.3.*" />
<PackageReference Include="Xamarin.Forms" Version="3.4.*" />
</ItemGroup>

<ItemGroup>
Expand Down