Feature/xamarin essentials events #1682

michaelstonis · 2018-07-05T22:45:06Z

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
There are no event bindings for Xamarin.Essentials today

What is the new behavior (if this is a feature change)?
This adds the ability to provide event binding for Xamarin.Essentials

What might this PR break?
Not likely anything, but there were some changes to the event binding program.

Please check if the PR fulfills these requirements

Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Other information:
I would potentially consider this a first pass. Everything in the Essentials world is a static class, so binding the same way we did before is not possible. Right now, the extensions are added to object, so as soon as you do a using Xamarin.Essentials;, every object is going to have these extension methods available. I don't love this, but I really couldn't think of a better approach.

catching-up

dnfclas · 2018-07-05T22:45:17Z

All CLA requirements met.

olevett · 2018-07-06T13:43:19Z

src/EventBuilder/EventBuilder.csproj

    <PackageReference Include="Serilog" Version="1.5.14" />
+    <PackageReference Include="NuGet.Core" Version="2.14.0" />
  </ItemGroup>
+<ItemGroup>


This formatting seems a bit inconsistent with the others, e.g. indent off by one

olevett · 2018-07-06T13:44:04Z

src/EventBuilder/Platforms/Essentials.cs

+                Directory.GetFiles(packageUnzipPath,
+                    "Xamarin.Essentials.dll", SearchOption.AllDirectories);
+
+            var latestVersion = xamarinForms.Last();//x => x.Contains("netstandard2.0"));


is the x.contains needed?

Originally I had it pinned at netstandard2.0, but then had to switch it to try to just get the last one. I am going to pin it at netstandard2.0.

olevett · 2018-07-06T13:45:31Z

src/EventBuilder/Cecil/StaticEventTemplateInformation.cs

+            {"Windows.Foundation.EventHandler`2", "EventHandler"}
+        };
+
+        private static string RenameBogusWinRTTypes(string typeName)


Given this is only being used for Xamarin.Essentials, do we need this slightly odd bodge?

I am going to kick it all out for now.

olevett · 2018-07-06T13:46:09Z

src/EventBuilder/Cecil/StaticEventTemplateInformation.cs

+
+            var garbageNamespaceList = new[]
+            {
+                "Windows.UI.Xaml.Data",


Likewise, are these namespaces sensible to exclude?

Same, I am cleaning all of the, seemingly, non-relevant stuff out of here.

Since this is designed for Xamarin.Essentials, these are not necessary

olevett · 2018-07-11T08:43:28Z

Thanks @michaelstonis!

@ghuntley not sure who has the ability to push this out as an extra nuget package, is this something you could help with?

Mrnikbobjeff · 2018-07-12T10:33:20Z

I would suggest tabling this until this has been delt with in their repository. I reckon this would break existing code.

michaelstonis · 2018-07-13T15:12:43Z

I will keep an eye on the Essentials package and update this once they finalize their event structure.

Mrnikbobjeff · 2018-07-26T19:35:55Z

@michaelstonis The event structure has been finalized. That block has been cleared.

michaelstonis · 2018-07-26T21:07:23Z

As soon as they release a new nuget with these in them, I will get this updated.

glennawatson · 2018-08-02T21:27:33Z

They released a new version a couple days ago https://www.nuget.org/packages/Xamarin.Essentials

Xamarin.Essentials 0.9.1-preview
Xamarin.Essentials: a kit of essential API's for your apps

michaelstonis · 2018-08-03T14:25:23Z

Cool. I am on it.

This also required changing the framework to netstandard 1.0, but I have no idea why

This now matches the standard event format. One thing that was immediately bad about the last implementation is that it caused a lot of chaff in intellisense, since every object would have these extensions. I changed this to not be extension methods, but just static instances that can be called from wherever and the experience is far better this way. I am open to reverting it though.

glennawatson · 2018-08-06T23:57:50Z

src/EventBuilder/Platforms/Essentials.cs

                    "Xamarin.Essentials.dll", SearchOption.AllDirectories);

-            var latestVersion = xamarinForms.First(x => x.Contains("netstandard2.0"));
+            var latestVersion = xamarinForms.First(x => x.Contains("netstandard1.0"));


Wonder if it's worthwhile not putting the version in?

glennawatson · 2018-08-06T23:58:36Z

src/EventBuilder/CommandLineOptions.cs

        XamForms,
        UWP,
-        Winforms
+        Winforms,


This is going to be fun doing TVOS who wins first :)

glennawatson · 2018-08-06T23:58:59Z

src/EventBuilder/EventBuilder.csproj

+    <PackageReference Include="NuGet.Core" Version="2.14.0" />
+  </ItemGroup>
+  <ItemGroup>
+    <None Update="XamarinEssentialsTemplate.mustache">


This one is None, other mustache above is Content, can we keep them the same type and put them into the same ItemGroup?

glennawatson · 2018-08-07T00:00:21Z

BTW @michaelstonis I think you just need to do a conflict resolve on the files at the moment to get this ready for finishing the PR, and very minor minor comments in review. Then I think we are ready to pull.

glennawatson · 2018-08-07T00:08:39Z

Hey @olevett you mentioned we might need a new NuGet package for the events? Should I get Oren/Geoffrey to help out?

Merge remote-tracking branch 'upstream/master' into feature/xamarin-essentials-events fix-up Tizen base platform implementation

…ssentials-events

glennawatson · 2018-08-07T21:50:22Z

Thanks @michaelstonis

Provides functionality to generate event mapping for Xamarin.Essentials

michaelstonis and others added 2 commits July 5, 2018 16:54

Merge pull request #1 from reactiveui/master

63e0f2a

catching-up

Provides functionality to generate event mapping for Xamarin.Essentials

93703bf

michaelstonis requested a review from a team July 5, 2018 22:45

olevett suggested changes Jul 6, 2018

View reviewed changes

michaelstonis added 3 commits July 6, 2018 11:02

removed WinRT reference filtering from StaticEventTemplateInformation

57d9305

Since this is designed for Xamarin.Essentials, these are not necessary

Pinning assembly to the netstandard2.0 version

92198c0

updating csproj formatting to be consistent with other projects

59c50b1

olevett approved these changes Jul 11, 2018

View reviewed changes

olevett added xamarin-forms xamarin-android xamarin-ios xamarin-mac labels Jul 11, 2018

olevett mentioned this pull request Jul 21, 2018

[WIP] feature: add xamarin essentials to reactiveui.events #1577

Closed

2 tasks

glennawatson added blocked caboodle labels Jul 21, 2018

michaelstonis added 2 commits August 6, 2018 19:50

update to latest packages

8f3b10d

This also required changing the framework to netstandard 1.0, but I have no idea why

glennawatson requested changes Aug 6, 2018

View reviewed changes

move XamarinEssentialsTemplate to same ItemGroup

83d5925

Merge remote-tracking branch 'upstream/master' into feature/xamarin-essentials-events fix-up Tizen base platform implementation

michaelstonis requested a review from a team August 7, 2018 00:36

michaelstonis requested review from a team August 7, 2018 00:36

Merge remote-tracking branch 'upstream/master' into feature/xamarin-e…

2916c40

…ssentials-events

glennawatson approved these changes Aug 7, 2018

View reviewed changes

glennawatson added 2 commits August 7, 2018 08:18

Merge branch 'master' into feature/xamarin-essentials-events

a259bda

Merge branch 'master' into feature/xamarin-essentials-events

b954949

glennawatson added this to the vNext milestone Aug 7, 2018

glennawatson merged commit 6fa6de2 into reactiveui:master Aug 7, 2018

glennawatson modified the milestones: vNext, 8.4.4 Aug 9, 2018

RLittlesII mentioned this pull request Aug 28, 2018

Create ReactiveUI.Events.XamEssentials? #1574

Closed

glennawatson pushed a commit that referenced this pull request Mar 23, 2019

Feature xamarin essentials events (#1682)

b895de5

Provides functionality to generate event mapping for Xamarin.Essentials

lock bot locked and limited conversation to collaborators Jun 25, 2019

Uh oh!

Feature/xamarin essentials events #1682

Feature/xamarin essentials events #1682

Uh oh!

Conversation

michaelstonis commented Jul 5, 2018

Uh oh!

dnfclas commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olevett commented Jul 11, 2018

Uh oh!

Mrnikbobjeff commented Jul 12, 2018

Uh oh!

michaelstonis commented Jul 13, 2018

Uh oh!

Mrnikbobjeff commented Jul 26, 2018

Uh oh!

michaelstonis commented Jul 26, 2018

Uh oh!

glennawatson commented Aug 2, 2018 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelstonis commented Aug 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glennawatson commented Aug 7, 2018

Uh oh!

glennawatson commented Aug 7, 2018

Uh oh!

glennawatson commented Aug 7, 2018

Uh oh!

Uh oh!

dnfclas commented Jul 5, 2018 •

edited

Loading

glennawatson commented Aug 2, 2018 •

edited by unfurl-links bot

Loading