Skip to content

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Jan 10, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is documentation improvement. Related to #1888

What is the current behavior? (You can also link to an open issue here)

When bootstrapping a new WPF project with ReactiveUI, I copy-pasted XAML markup snippet from API docs page and it didn't compile due to missing xmlns directives and wrong x:Class syntax.

What is the new behavior (if this is a feature change)?

Now, the sample compiles, and uses correct syntax and correct xmlns directives.

What might this PR break?

Nothing.

@worldbeater worldbeater requested review from a team January 10, 2019 21:31
@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #1899 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1899   +/-   ##
======================================
  Coverage    66.4%   66.4%           
======================================
  Files         110     110           
  Lines        4387    4387           
  Branches      579     579           
======================================
  Hits         2913    2913           
  Misses       1305    1305           
  Partials      169     169
Impacted Files Coverage Δ
src/ReactiveUI.Wpf/ReactiveWindow.cs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e20f25...d9ead56. Read the comment docs.

@glennawatson glennawatson merged commit 3246efa into master Jan 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the correct-reactive-window branch January 10, 2019 21:45
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants