fix: Combobox not updating when using Bind() generated ViewModelViewHost #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elipriaulx
reviewed
Jan 16, 2019
elipriaulx
reviewed
Jan 16, 2019
elipriaulx
reviewed
Jan 16, 2019
elipriaulx
previously approved these changes
Jan 16, 2019
Co-Authored-By: glennawatson <[email protected]>
Co-Authored-By: glennawatson <[email protected]>
Co-Authored-By: glennawatson <[email protected]>
RLittlesII
previously approved these changes
Jan 16, 2019
worldbeater
previously approved these changes
Jan 16, 2019
glennawatson
dismissed stale reviews from worldbeater and RLittlesII
via
e344775
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
=========================================
Coverage ? 66.67%
=========================================
Files ? 110
Lines ? 4372
Branches ? 578
=========================================
Hits ? 2915
Misses ? 1287
Partials ? 170
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This fixes #1905 -- where a combobox does not correctly update in WPF if the combobox item is selected.
What is the current behavior? (You can also link to an open issue here)
The boxes remain empty.
What is the new behavior (if this is a feature change)?
Due to the fact Combobox item's are cloned when they become the main view item, WhenActivated events wouldn't be fired correctly. Now also include "IsHitTestEnabled" in the list of included events we monitor.
Also changed so the ViewModelViewHost doesn't rely on the RxUI binding which can potentially give some performance boosts but also might reduce memory leak potential.
What might this PR break?
Hopefully nothing.