Skip to content

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Jan 26, 2019

  • Modified the Events projects to handle compiling on mac
  • Android events now look for desired version on both windows/mac
  • Modified the azure to run tests/ci on both windows/mac
  • If not compiling on windows exclude uwp/net461
  • Fix the build.sh to use the same as what the cake build team uses, and uses a global tool
  • Turn off sourcelink for mac building temporarily. We don't use it for generating the NuGet packages anyway
  • Modified Fody to not rely on TargetFramework for where to copy files from.
  • Also fixed Fody compilation when it copies from the helper project, to wait until the sub-projects have a chance to compile first.

@glennawatson glennawatson requested review from a team January 26, 2019 19:27
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #1932 into master will increase coverage by 2.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1932     +/-   ##
=========================================
+ Coverage   64.49%   67.39%   +2.9%     
=========================================
  Files          99       99             
  Lines        3585     4815   +1230     
  Branches      903      465    -438     
=========================================
+ Hits         2312     3245    +933     
- Misses       1138     1443    +305     
+ Partials      135      127      -8
Impacted Files Coverage Δ
...rc/ReactiveUI/Activation/CanActivateViewFetcher.cs 33.33% <0%> (-16.67%) ⬇️
src/ReactiveUI.Winforms/Registrations.cs 54.54% <0%> (-7.96%) ⬇️
...ctiveUI/Bindings/Property/PropertyBindingMixins.cs 80% <0%> (-7.5%) ⬇️
...ReactiveUI/Scheduler/WaitForDispatcherScheduler.cs 75.86% <0%> (-6.5%) ⬇️
...ctiveUI/ReactiveCommand/CombinedReactiveCommand.cs 70.14% <0%> (-6.22%) ⬇️
src/ReactiveUI/Mixins/AutoPersistHelper.cs 91.39% <0%> (-5.44%) ⬇️
...ommand/CreatesCommandBindingViaCommandParameter.cs 91.17% <0%> (-5.12%) ⬇️
...activeUI/Bindings/Command/CreatesCommandBinding.cs 77.35% <0%> (-4.46%) ⬇️
...orms/windows-common/AutoDataTemplateBindingHook.cs 79.54% <0%> (-3.79%) ⬇️
...veUI/Interactions/UnhandledInteractionException.cs 37.03% <0%> (-2.97%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c07e9...ca96b47. Read the comment docs.

@glennawatson glennawatson changed the title (wip) housekeeping: Make ReactiveUI compile on VisualStudio for Mac housekeeping: Make ReactiveUI compile on VisualStudio for Mac Jan 31, 2019
@RLittlesII RLittlesII merged commit 26ac371 into master Jan 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the vs4mac-compilation branch January 31, 2019 22:43
glennawatson added a commit that referenced this pull request Mar 23, 2019
* housekeeping: allow for vs4mac copilation

* updated to use better target for fody

* Update the main CI to do mac as well

* fix syntax issues in azure yaml

* go back to old version of visual studio

* trying to get the proper mack version to compile

* cleanup android generation
@lock lock bot locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants