Skip to content

Conversation

glennawatson
Copy link
Contributor

Fixes #2021

@glennawatson glennawatson requested review from a team May 12, 2019 06:25
@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #2023 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2023      +/-   ##
==========================================
- Coverage   60.78%   60.18%   -0.61%     
==========================================
  Files         115      116       +1     
  Lines        4580     4448     -132     
  Branches      656      638      -18     
==========================================
- Hits         2784     2677     -107     
+ Misses       1614     1598      -16     
+ Partials      182      173       -9
Impacted Files Coverage Δ
src/ReactiveUI/EventManagers/WeakEventManager.cs 60.43% <0%> (-3.33%) ⬇️
src/ReactiveUI/ReactiveCommand/ReactiveCommand.cs 79.32% <0%> (-0.89%) ⬇️
...rvableCollectionChangedToListChangedTransformer.cs 86.66% <0%> (ø)
src/ReactiveUI/Legacy/ReactiveDerivedCollection.cs 40.67% <0%> (+0.4%) ⬆️
...eactiveUI/ReactiveCommand/ReactiveCommandMixins.cs 100% <0%> (+3.77%) ⬆️
...tiveUI/ReactiveObject/IReactiveObjectExtensions.cs 100% <0%> (+4.54%) ⬆️
src/ReactiveUI/Comparers/OrderedComparer.cs 83.33% <0%> (+19.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b78c4...4b22e5f. Read the comment docs.

@glennawatson glennawatson merged commit afdf520 into master May 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the issue-2021 branch May 12, 2019 06:41
madmonkey pushed a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019
@lock lock bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] WPF: WhenActivated not fired when in ViewModelViewHost
1 participant