Support for the Enabled property of Components in the WinForms command binder #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the WinForms command binder
anaisbetts
pushed a commit
that referenced
this pull request
Sep 11, 2014
Support for the Enabled property of Components in the WinForms command binder
|
Looks great @vanderkleij, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to bind a command to a System.Windows.Forms.ToolStripButton, I noticed that its enabled state was not updated correctly with changes to the command's CanExecute. Upon further investigation, this was caused by the fact that ToolStripButton is not a Control, but derives from Component instead. Apparently, there are Components that are a lot like Controls and should therefor support command binding like Controls do. ReactiveUI only updates the Enabled property for classes deriving from Control though.
I've added the test "CommandBinderAffectsEnabledStateForComponents" to illustrate this problem. The changes to CreatesWinformsCommandBinding make the test pass.
I've replaced the check for targetType being a Control with a check for targetType being a Component (Control derives from Component). Alternatively, we could also scrap this check altogether and only do the check for an Enabled property on targetType.