Test on PHP 8.2 #466
Merged
Test on PHP 8.2 #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
1.x-test-on-php-8.2
branch
from
a41add9 to
414d491
Compare
Member
Author
|
@clue With a fix from PHPUnit's side yesterday, all checks are now green 🎉 |
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus
force-pushed
the
1.x-test-on-php-8.2
branch
from
414d491 to
f0b4859
Compare
clue
approved these changes
Aug 23, 2022
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it.
Refs: reactphp/event-loop#258
Builds on top of #459