1/3 Replace legacy user settings API #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
force-pushed
the
feature/settings+replace-legacy
branch
from
9660919 to
c2ccd13
Compare
mickael-menu
force-pushed
the
feature/settings+replace-legacy
branch
from
f906a5f to
680d74a
Compare
mickael-menu
force-pushed
the
feature/settings+replace-legacy
branch
from
680d74a to
fb34c59
Compare
mickael-menu
force-pushed
the
feature/settings+replace-legacy
branch
from
5509e6a to
1eee3d8
Compare
mickael-menu
force-pushed
the
feature/settings+replace-legacy
branch
from
9bef708 to
9748c7e
Compare
mickael-menu
commented
Aug 16, 2022
|
|
||
| resourcePager.adapter = adapter | ||
| resourcePager.direction = publication.metadata.effectiveReadingProgression | ||
| resetAdapter() |
There was a problem hiding this comment.
The adapter can now be reset when changing settings that require a relayout (e.g. reading progression).
| private lateinit var resourcesSingle: List<PageResource> | ||
| private lateinit var resourcesDouble: List<PageResource> | ||
|
|
||
| lateinit var preferences: SharedPreferences |
There was a problem hiding this comment.
The EpubNavigatorFragment is in "legacy mode" (with SharedPreferences settings) if a baseUrl is provided. If it is null, we switch to the new Settings API.
|
|
||
| override val readingProgression: ReadingProgression | ||
| get() = publication.metadata.effectiveReadingProgression | ||
| get() = viewModel.readingProgression |
There was a problem hiding this comment.
The readingProgression is now dynamic as it's also a setting.
qnga
reviewed
Sep 4, 2022
readium/navigator/src/main/java/org/readium/r2/navigator/epub/EpubNavigatorViewModel.kt
Outdated
Show resolved
Hide resolved
readium/navigator/src/main/java/org/readium/r2/navigator/epub/css/ReadiumCss.kt
Show resolved
Hide resolved
qnga
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review notes
The Settings API PRs are numbered in the order of merge, but should be reviewed in reverse order, starting with #141.
However, you might want to start by reading the documentation that is in this PR, as it is the most up-to-date:
This PR: