Skip to content

Don't restart utterance in TTS when submitting the same preferences again #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Don't restart utterance in TTS when submitting the same preferences again #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion readium/navigators/media/tts/src/main/java/org/readium/navigator/media/tts/TtsNavigator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ public class TtsNavigator<S : TtsEngine.Settings, P : TtsEngine.Preferences<P>,

override fun submitPreferences(preferences: P) {
player.submitPreferences(preferences)
player.restartUtterance()
}

private fun navigatorPlayback(playback: TtsPlayer.Playback, utterance: TtsPlayer.Utterance) =
Expand Down
11 changes: 10 additions & 1 deletion readium/navigators/media/tts/src/main/java/org/readium/navigator/media/tts/TtsPlayer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ internal class TtsPlayer<S : TtsEngine.Settings, P : TtsEngine.Preferences<P>,
initialPreferences

init {
submitPreferences(initialPreferences)
submitPreferencesForSure(initialPreferences)
}

fun play() {
Expand Down Expand Up @@ -560,6 +560,15 @@ internal class TtsPlayer<S : TtsEngine.Settings, P : TtsEngine.Preferences<P>,
}

override fun submitPreferences(preferences: P) {
if (preferences == lastPreferences) {
return
}

submitPreferencesForSure(preferences)
restartUtterance()
}

private fun submitPreferencesForSure(preferences: P) {
lastPreferences = preferences
engineFacade.submitPreferences(preferences)
contentIterator.language = engineFacade.settings.value.language
Expand Down