Fixed docker permissions on results folder. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced Dockerfile with multi-stage build and security best practices - Added Docker build, run, and test scripts with Redis-specific configurations - Created GitHub Actions workflows for PR validation, master publishing, and release publishing - Added docker-compose.yml for local development with Redis - Updated documentation with Docker usage examples - Configured for redis-performance/vector-db-benchmark Docker Hub repository - Default configuration: engines=redis, dataset=random-100, experiment=redis-m-16-ef-64 - Multi-platform support (linux/amd64, linux/arm64) - Security scanning with Trivy for releases
- Updated PR validation to trigger on update-redisearch branch
- Updated publishing workflow to use update-redisearch branch instead of master
- Updated Docker tags to use update-redisearch-{sha} format
- Updated documentation to reflect correct default branch
…ion, and performance monitoring - Add --describe command for datasets and engines with columnar display - Implement real-time performance summaries (QPS, P50/P95 latency) - Add comprehensive dataset validation system with GitHub Actions - Complete dataset metadata with vector_count and description fields - Improve download reliability with proper HTTP headers - Standardize precision formatting (0.01 increments up to 0.97, then 0.0025) - Enhanced Docker configurations for better Redis testing defaults - Add validation documentation and automated CI/CD checks This maintains backward compatibility while significantly improving usability, data quality, and performance insights for vector database benchmarking.
- Add Poetry installation to validate-datasets workflow - Use --no-root to install dependencies without packaging the project - Run validation script with 'poetry run' to access all dependencies - Fixes ModuleNotFoundError for stopit and other dependencies when testing --describe functionality
🐳 Docker Build Validation✅ Docker build successful! Platforms tested:
Git SHA: Docker Hub Status: ✅ Docker Hub credentials configured Image details:
Tests performed:
The Docker image is ready for deployment! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.