Skip to content

Conversation

peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Sep 21, 2023

option DisableIndentity and ContextTimeoutEnabled sometimes are not available or not propagate betweend option types.

BTW I think it is strange that exists an option CredentialsProvider but we only use in the simple case, why Universal, Ring or Cluster does not use it?

same for Limiter

       CredentialsProvider func() (username string, password string)
	// Limiter interface used to implement circuit breaker or rate limiter.
	Limiter Limiter

@peczenyj peczenyj changed the title must propagage missing fields Option types must propagage missing fields Sep 21, 2023
@ofekshenawa ofekshenawa merged commit a5fe174 into redis:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants