Skip to content

fix missing fields in different Options #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2023
Merged

fix missing fields in different Options #2757

merged 4 commits into from
Oct 30, 2023

Conversation

chenjie199234
Copy link
Contributor

@chenjie199234 chenjie199234 commented Oct 14, 2023 •
edited
Loading

@chayim
Copy link
Contributor

chayim commented Oct 25, 2023

@ofekshenawa does this make sense in the next release?

ofekshenawa
ofekshenawa approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@ofekshenawa ofekshenawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofekshenawa ofekshenawa merged commit fd13da4 into redis:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ofekshenawa ofekshenawa ofekshenawa approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenjie199234 @chayim @ofekshenawa