Introduce Config pattern #2342
Closed
Introduce Config pattern #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
requested review from
gkorland,
mina-asham and
yangbodong22011
and removed request for
gkorland,
mina-asham and
yangbodong22011
mina-asham
reviewed
Jan 18, 2021
There was a problem hiding this comment.
I like the Config pattern in general, but I feel like this is something that we need to put more thought into, I have always wanted to see a more immutable version of Jedis where you create the client/pool/cluster and that's it, if you want to modify it you create another one that with a builder-config pattern is really awesome I think.
I think we should split fixing #1824 and this config change as well as it's easier to fix that bug.
sazzad16
force-pushed
the
config-pattern
branch
3 times, most recently
from
16ddcf8 to
abf9563
Compare
sazzad16
force-pushed
the
config-pattern
branch
from
abf9563 to
80e529b
Compare
sazzad16
force-pushed
the
config-pattern
branch
from
80e529b to
8b92bd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is approved, we can extend it to JedisPool, JedisCluster, everywhere else.
Resolves #1824