Support Sentinel with TLS (II) #2403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkorland
reviewed
Mar 14, 2021
mina-asham
suggested changes
Mar 24, 2021
From @mina-asham, I would avoid `parallelStream` here: 1. I don't really think it's that intensive of an operation that you are going to get a gain 2. It's going to use the shared forkjoin pool and might affect other operations Also we can use the method reference for the map operation. Co-authored-by: Mina Asham <[email protected]>
mina-asham
previously approved these changes
Mar 24, 2021
Conflicts: src/main/java/redis/clients/jedis/JedisSentinelPool.java src/test/java/redis/clients/jedis/tests/SSLJedisSentinelPoolTest.java
dengliming
reviewed
Mar 25, 2021
mina-asham
approved these changes
Mar 25, 2021
dengliming
approved these changes
Mar 29, 2021
sazzad16
added a commit
to sazzad16/jedis
that referenced
this pull request
Mar 31, 2021
sazzad16
added a commit
that referenced
this pull request
Apr 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension to #2445