Skip to content

Conversation

Avital-Fine
Copy link
Contributor

Description

closes #1961, closes #1962, closes #1963, closes #1964


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@Avital-Fine Avital-Fine requested a review from leibale February 28, 2022 16:43
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #2014 (df4a8bf) into master (ac7d50c) will decrease coverage by 0.08%.
The diff coverage is 91.66%.

❗ Current head df4a8bf differs from pull request most recent head da1ee8f. Consider uploading reports for the commit da1ee8f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
- Coverage   94.94%   94.86%   -0.09%     
==========================================
  Files         358      364       +6     
  Lines        3343     3386      +43     
  Branches      409      411       +2     
==========================================
+ Hits         3174     3212      +38     
- Misses         85       89       +4     
- Partials       84       85       +1     
Impacted Files Coverage Δ
packages/client/lib/commands/BITFIELD.ts 100.00% <ø> (ø)
packages/client/lib/commands/LMOVE.ts 100.00% <ø> (ø)
packages/client/lib/commands/SORT.ts 100.00% <ø> (ø)
packages/client/lib/commands/COMMAND_LIST.ts 60.00% <60.00%> (ø)
packages/client/lib/client/commands-queue.ts 80.39% <100.00%> (+0.12%) ⬆️
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/cluster/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/BITFIELD_RO.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/DUMP.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/GEOADD.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7d50c...da1ee8f. Read the comment docs.

@leibale leibale merged commit 515adf1 into master Mar 27, 2022
@leibale leibale deleted the OBJECT-Commands branch March 27, 2022 17:35
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
* Support OBJECT [...] commands

* move commands to cluster/commands.ts

Co-authored-by: leibale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants