Skip to content

Conversation

@mDibyo
Copy link
Contributor

@mDibyo mDibyo commented Nov 15, 2017

redux-loop/index.d.ts relies on the AnyAction type introduced in [email protected] (reduxjs/redux#2467 (comment)).

AFAIK, the redux-loop implementation itself doesn't depend on features introduced in 3.7.2.

If we want to keep the peerDependency at redux@^3.0.0, an alternate solution would be removing the AnyAction import and defining it ourselves. This doesn't seem like that big a deal: https://github.com/reactjs/redux/blob/master/index.d.ts#L25

@bdwain
Copy link
Member

bdwain commented Nov 20, 2017

makes sense. 3.7.2 has been out a while. i don't see much benefit in using an earlier version of 3.

thanks!

@bdwain bdwain merged commit f59e154 into redux-loop:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants