Unable to use class level functions as callback

[michaelmohamed]

I am on the latest version of redux, and i am unable to use callbacks as array(' $this, 'function_name');

I am getting an error that function_exists expects param 1 to be a string.

How do I use functions inside another class as a function?

Thanks!

[dovy]

You're right, because of the complexity for marginal benefits.

Just make a wrapper function to call the class method and you'll be good.

function wrap_for_class() {
    Class_Name::run_method();
}

Have a great day.

[michaelmohamed]

I don't think it should be very complex. I have modified framework.php; _field_input(), and _validate_values.

from:

 if ( isset( $field['validate_callback'] ) && function_exists( $field['validate_callback'] ) ) 

to:

 if ( ( isset( $field['validate_callback'] ) && is_callable( $field['validate_callback'] ) ) || ( is_string( $field['validate_callback'] ) && function_exists( $field['validate_callback'] ) ) ) 

This works with class level and anonymous functions as callbacks.

I hope helps anyone who may be using callbacks from within a specified class.

Thank You,

[dovy]

Are you sure this works properly? I'm not sure since $field['validate_callback'] is what's used in _validate_values, and not callback_callback.

[michaelmohamed]

Good catch! I updated my last comment. I should have copied and pasted; rather than type by hand.

[michaelmohamed]

Here is a gist of the change:

https://gist.github.com/echo1consulting/6a7ec19db0e206c14f98

Sorry, I am new to git, and working on figuring out pull requests.

I hope this helps. Thank you for contributing the awesome plugin!

[dovy]

Just pushed in 3.3.7 that's about to go to WP.org. Thanks!