Multiselect with require

Hi,

There is an issue with multiselect field and require option. I've one multiselect field with few options. Below there are simple text fields that should be displayed when specific option is selected. It's working fine when I select only one option in the multiselect field. When I select additional options all text fields are hidden.

It's working fine after I save the panel (PHP checks the visibility) but it isn't working when I modify the multiselect value (JS check for visibility).

The values from multiselect are returned in JS as array in array so the check if ( $.inArray( checkValue, parentValue ) != -1 ) { from redux.js line 773 isn't working.

You can check the issue with this sample config

array(
    'id'       => 'opt-socials',
    'type'     => 'select',
    'multi'    => true,
    'sortable' => true,
    'title'    => __( 'Socials', 'redux-framework-demo' ),
    'options'  => array(
        'facebook' => 'Facebook',
        'twitter'  => 'Twitter',
    ),
),
array(
    'id'       => 'opt-socials-facebook',
    'type'     => 'text',
    'title'    => __( 'Text Option - Facebook', 'redux-framework-demo' ),
    'required' => array( 'opt-socials', '=', 'facebook' ),
),
array(
    'id'       => 'opt-socials-twitter',
    'type'     => 'text',
    'title'    => __( 'Text Option - Twitter', 'redux-framework-demo' ),
    'required' => array( 'opt-socials', '=', 'twitter' ),
),

[kprovance]

Version information missing. Please review: https://github.com/ReduxFramework/redux-framework/blob/master/CONTRIBUTING.md

Redux Framework: 3.3.9.8
WordPress: 4.0
dev_mode: on

Clear Redux embedded into custom theme. No errors in browser console.

Cheers :)

[someonegp]

Hi

I think that the JS checking should look like below. I didn't have time to check all the fields with this code but it works for multi selects.

case '=':
case 'equals':
    //if value was array
    if ( $.isArray( checkValue ) ) {
        if ( $.inArray( parentValue, checkValue ) !== -1 ) {
            show = true;
        }
    } else {
        if ( parentValue === checkValue ) {
            show = true;
        } else if ( $.isArray( parentValue ) ) {
            parentValue.map ( function( parentValueItems ) {
                 if ( $.inArray( checkValue, parentValueItems ) !== -1 ) {
                     show = true;
                 }
            });
        }
    }
    break;

[kprovance]

@jaikme , please do not piggy back other tickets. Please open your own with the required information from our posting guidelines.

Regardless, your required statement is malformed. See: http://docs.reduxframework.com/core/the-basics/required/

[kprovance]

Looks like a good portion of our required logic doesn't play well with the select set to multi. I've got 'contains' and 'not_contains' working in the 3.3.9.15 push. I reckon I'll fix the others shortly as well.

[kprovance]

v3.3.9.15 push should take care of this. :)