Skip to content

GoogleWebFont subset does not work in IE #3321

@KostaStolbunsky

Description

@KostaStolbunsky

Support Hash

Steps to reproduce

Choose Arimo Google web font and set Hebrew subset
https://www.screencast.com/t/GmYl5JL5CP

Actual Behavior

In browser source code it looks as follows
<link href="http://fonts.googleapis.com/css?family=Arimo:400,700&amp;subset=hebrew" rel="stylesheet">

Expected Behavior

While Chrome, Safari and Firefox interpret &amp; sign as expected, Internet Explorer (including Edge and below) does not recognise it and as a result a subset does not loaded.

Any Error Details (PHP/JavaScript)

In file ReduxCore/inc/fields/typography/field_typography.php
Lines 612, 654
$link .= "&amp;subset=" . implode( ',', $subsets );

Changed &amp; to & as a dirty workaround and now subset is loaded in IE as well

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions