Skip to content

Conversation

@JonasDoebertin
Copy link

Introducing an option to choose where the dynamic CSS and Google Fonts will be applied (as mentioned in #1590).

'output_location' => array('frontend', 'login', 'admin'),

This allows to toggle outputting the CSS on the frontend, the login/register pages, and even the backend independently. The default value, set in set_default_args, is array('frontend') to make this option backward compatible.

Please let me know if you have any concerns about this approach.

Also, my editor applied the provided .editorconfig configuration and thus remove quite a lot of trailing whitespace. If you add ?w=1 to the URL, you should be able to view only non-whitespace changes.

@JonasDoebertin
Copy link
Author

Added an extra check to catch blank values and empty arrays for the argument.

@JonasDoebertin
Copy link
Author

Is there any chance we can get this approach (or a similar solution) merged and tagged in the near future?

I'd really like to finish up a project that needs the Redux-generated CSS and Google Fonts on the login page, too. However, I can only proceed if there's an officially tagged release containing this change.

Please let me know, if I can do anything more!

@dovy
Copy link
Contributor

dovy commented Aug 29, 2014

Sorry, Kevin is waiting on me. My son has been in the hospital since Tuesday. I'll get to this as I am able.

@JonasDoebertin
Copy link
Author

Oh man, I'm sorry to hear that. All the best to him! I hope he'll be well soon!

@dovy
Copy link
Contributor

dovy commented Aug 29, 2014

Should be fine. My twins have been in the hospital so much recently. Oy.

dovy added a commit that referenced this pull request Sep 24, 2014
…amic CSS to the admin panel or login screen.
@dovy
Copy link
Contributor

dovy commented Sep 24, 2014

Sorry for the delay on this! Finally got it merged in. Thanks for the great idea!

@dovy dovy closed this Sep 24, 2014
@JonasDoebertin
Copy link
Author

Awesome! Thanks a lot! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants