-
Notifications
You must be signed in to change notification settings - Fork 585
allow for including redux in non isolation unit testing #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: ReduxCore/inc/welcome/welcome.php
Member
|
Instead of adding a new file for the static setcookie function, I'm going to add it into our functions class instead. Plus, we're a few versions ahead of .1. I will credit you accordingly. :-) |
Author
|
@kprovance cheers ;) if it helps - I think that build fail is from me checking the flag |
Member
|
Added to upcoming push! ;-) |
kprovance
added a commit
that referenced
this pull request
Apr 30, 2015
Signed-off-by:KProvance <[email protected]>
kprovance
added a commit
that referenced
this pull request
Apr 30, 2015
Signed-off-by:KProvance <[email protected]>
kprovance
added a commit
that referenced
this pull request
Apr 30, 2015
Signed-off-by:KProvance <[email protected]>
kprovance
added a commit
that referenced
this pull request
Apr 30, 2015
Signed-off-by:KProvance <[email protected]>
kprovance
added a commit
that referenced
this pull request
Apr 30, 2015
Signed-off-by:KProvance <[email protected]>
kprovance
added a commit
that referenced
this pull request
Apr 30, 2015
Signed-off-by:KProvance <[email protected]>
kprovance
added a commit
that referenced
this pull request
Apr 30, 2015
Signed-off-by:KProvance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
pris to fix: cant run withphpunit: PHP Warning:headers already sent by (output started at bootstrap.php:53) pluggable.php on line 1196.I've found that the main issue that was causing my plugin unit tests to fail was the use of php
setcookies()function writingheaders(), to solve this I created areduxCookieclass that I could mock or overwrite in my unit tests.I've also added the following to the
pr:condributing.mdcb7b9f2reduxCookieclass 3193533